Thanks for the effort. The docblocks in the Model classes are very useful for auto-completion. why did you remove them?

Besides, I would start with phpstan itself instead of larastan and with level 1

Just did a quick check on my local wth phpstan itself. found 9 errors on level 1 and 256 errors on level 2. shouldn't be difficult to fix them.

The docblocks in the Model classes are very useful for auto-completion. why did you remove them?

Because some of them were wrong (array instead of Collection, eg.

I would start with phpstan itself instead of larastan and with level 1

Phpstan without Larastan doesn't work, because Larastan is what makes sense of the loads of 'magic' in Laravel. There's also a level 0, but level 0 and 1 and 2 are all simple enough.

found 9 errors on level 1 and 256 errors on level 2. shouldn't be difficult to fix them.

Many of those 256 might be easy, and some of them will be impossible, because of Laravel's PHP magic. Larastan 'fixes' that with its Phpstan extensions. You also need fewer inline @var then.

Phpstan without Larastan doesn't work, because Larastan is what makes sense of the loads of 'magic' in Laravel. There's also a level 0, but level 0 and 1 and 2 are all simple enough.

I think its just configuration, it has worked on Laravel itself. should be easy to make it work on Vito as well.

You can copy Larastan functionality, but why would you? That's why Larastan exists. It sounds like you're against Larastan specifically. Why? I like it. It covers all the Laravel magic, you can code like you're used to. You can even keep all the class @property, but they do have to be correct (Collection instead of array etc). Larastan won't overwrite manual @property tags. Downside of manual property tags is that they might be nonsense, and you won't know. For instance what's up with auto_update and security_updates in Server? Are those columns? Do they exist? They're in $fillable too, but not in any migration. Do they still exist, or is it just the @property tag that still exists?

Anyway, you're the boss, you decide if and how you want static analysis. I think it already found a few issues even at level 2.

When the 2 mixed options are enabled, I expect many more errors, many of which aren't real errors, but Phpstan won't understand the code, because of Laravel magic handled by Larastan.

When the 2 mixed options are enabled, I expect many more errors, many of which aren't real errors, but Phpstan won't understand the code, because of Laravel magic handled by Larastan.

Many of those are Filament errors, but Filament doesn't provide Phpstan extensions, so you'd need to better type, and/or make custom extensions. I think. I don't know Filament at all.

Lets keep this open for a bit. Need to think more. Still have a bit of doubts of adding phpstan or not 🤔

Still have a bit of doubts of adding phpstan or not 🤔

It is a hassle getting it to work, but when it does it's nice to have an extra layer of protection.

I totally agree with the need for such tool as the bigger the project goes and more contributors come in, we need more protection. I need to figure out what setup is the best for Vito.